feat: Allow ENS resolver to answer more queries #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding note to self that I can implement in the morning: if the name arg in resolve() is farcaster.eth, we should pass that request to the ENS public resolver. This allows the farcaster.eth name itself to have onchain records while all subnames read from the fname registry. Edit: implemented this. The owner of farcaster.eth can set records on the ENS public resolver (resolver.eth) even if the name uses a different resolver, and requests will pass through seamlessly. Figured this was cleaner than adding all the relevant code to the FnameResolver directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Accompanies farcasterxyz/fname-registry#505 to make nice ENS profiles from fnames. I also added additional checks on the CCIP Read callback function for extra safety.
I wasn't sure what the version should be, so left that untouched for now.
Change Summary
Adds support for
addr(node, cointype)andtext(node, key)lookups by changing the EIP-712 type.Merge Checklist
PR-Codex overview
This PR focuses on enhancing the
FnameResolvercontract and its related tests by introducing new parameters, modifying function signatures, and improving error handling for resolver functions.Detailed summary
pre-commithook in.rusty-hook.toml.FNAME_RESOLVER_DNS_ENCODED_NAMEandFNAME_RESOLVER_PASSTHROUGH_ADDRESSenvironment variables.DeploymentParamsstruct andrunDeployfunction inscript/DeployL1.s.sol.FnameResolvercontract with new mappings for allowed functions and text records.resolveandresolveWithProoffunctions to improve validation and error handling.MockResolvercontract for testing purposes.FnameResolverTestto cover new functionality and edge cases.